Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deepKeys() #94

Merged
merged 8 commits into from
Feb 17, 2022
Merged

Add deepKeys() #94

merged 8 commits into from
Feb 17, 2022

Conversation

Richienb
Copy link
Contributor

Fixes #93

@Richienb
Add deepKeys()
3b7c465 
Signed-off-by: Richie Bendall <[email protected]>
@Richienb
Copy link
Contributor Author

Richienb commented Feb 13, 2022 •
edited
Loading

The PR is complete, but an AVA bug is causing CI to fail

@sindresorhus
Copy link
Owner

// @mmkal

@sindresorhus
Copy link
Owner

But the one that adds it should make sure to also document the mentioned use-cases for it.

Should mention all the use-cases.

mmkal
mmkal reviewed Feb 14, 2022
View reviewed changes
mmkal
mmkal reviewed Feb 14, 2022
View reviewed changes
@Richienb
Add use-case
0e6d467 
Signed-off-by: Richie Bendall <[email protected]>
@Richienb
Track path in array
cce65bc 
Signed-off-by: Richie Bendall <[email protected]>
@Richienb
Return an array
c8fb90e 
Signed-off-by: Richie Bendall <[email protected]>
@Richienb
De-duplicate
2f39ff6 
Signed-off-by: Richie Bendall <[email protected]>
mmkal
mmkal reviewed Feb 15, 2022
View reviewed changes
@Richienb
Include paths for all indexes
5660a53 
Signed-off-by: Richie Bendall <[email protected]>
@Richienb Richienb marked this pull request as ready for review February 16, 2022 09:04
@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

sindresorhus
sindresorhus reviewed Feb 16, 2022
View reviewed changes
sindresorhus
sindresorhus reviewed Feb 16, 2022
View reviewed changes
mmkal
mmkal reviewed Feb 16, 2022
View reviewed changes
test.js
}), [
'a\\.b.c.d',
'a\\.b.c.d[0]',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to be extra thorough you could cover the case where an array contains a complex object too, but I imagine it’s fine.

@sindresorhus sindresorhus merged commit 3902c64 into sindresorhus:main Feb 17, 2022
@sindresorhus
Copy link
Owner

Looks good :)

@AuthorProxy
Copy link
Contributor

@mmkal it doesn't work for empty arrays or objects #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmkal mmkal mmkal left review comments

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deepKeys helper?
4 participants
@Richienb @sindresorhus @AuthorProxy @mmkal